-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web-wallet: Improve Migration Functionality #3268
Conversation
a02db26
to
44b0b66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The idea to throw an error when the Reown project ID is missing makes sense to me if migrate
is enabled.
I noticed that on migration it can take a while before the wallet syncs again. If possible, it would probably be nice to trigger a sync call to the Dusk chain. This will probably take away some questions/fear from users when the funds do not show up.
This happens by default, as the Reown is initialized no matter if migrate is enabled or not – I don't think this is optimal, but, with the way the code is currently structured, it is what it is. So, if a project ID is missing, an error will be thrown from Reown initialization (however, the app won't break). If I was to throw an error explicitly, then the application wouldn't load. |
That's a good suggestion, however, the problem is that, currently, we have no way to check if the transaction has been processed by Messina. So just triggering a sync after the migration request is on chain, will not update the balance. I propose we add an info banner on the last step, saying that the migration request has been received and will be processed in the background. |
Messina accepts the transaction to be finalized quicker than the migration UX does. The only scenario in which it would not update is if there is a pretty large queue, so I think we can do both. But the info banner is definitely a must in my opinion. |
0715765
to
f48f12a
Compare
I experimented with this, seems like triggering a sync 15 seconds after a successful confirmation does the job in most cases. |
f48f12a
to
5699efe
Compare
web-wallet/src/lib/containers/MigrateContract/MigrateContract.svelte
Outdated
Show resolved
Hide resolved
89c0dc6
to
4a1dff9
Compare
Resolves #3267
Follow the linked issue for details on the changes delivered.