Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Improve Migration Functionality #3268

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

nortonandreev
Copy link
Contributor

Resolves #3267

Follow the linked issue for details on the changes delivered.

HDauven
HDauven previously approved these changes Dec 21, 2024
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The idea to throw an error when the Reown project ID is missing makes sense to me if migrate is enabled.

I noticed that on migration it can take a while before the wallet syncs again. If possible, it would probably be nice to trigger a sync call to the Dusk chain. This will probably take away some questions/fear from users when the funds do not show up.

@nortonandreev
Copy link
Contributor Author

nortonandreev commented Dec 22, 2024

The idea to throw an error when the Reown project ID is missing makes sense to me if migrate is enabled.

This happens by default, as the Reown is initialized no matter if migrate is enabled or not – I don't think this is optimal, but, with the way the code is currently structured, it is what it is. So, if a project ID is missing, an error will be thrown from Reown initialization (however, the app won't break).

If I was to throw an error explicitly, then the application wouldn't load.

@nortonandreev
Copy link
Contributor Author

I noticed that on migration it can take a while before the wallet syncs again. If possible, it would probably be nice to trigger a sync call to the Dusk chain. This will probably take away some questions/fear from users when the funds do not show up.

That's a good suggestion, however, the problem is that, currently, we have no way to check if the transaction has been processed by Messina. So just triggering a sync after the migration request is on chain, will not update the balance.

I propose we add an info banner on the last step, saying that the migration request has been received and will be processed in the background.

@HDauven
Copy link
Member

HDauven commented Dec 22, 2024

I noticed that on migration it can take a while before the wallet syncs again. If possible, it would probably be nice to trigger a sync call to the Dusk chain. This will probably take away some questions/fear from users when the funds do not show up.

That's a good suggestion, however, the problem is that, currently, we have no way to check if the transaction has been processed by Messina. So just triggering a sync after the migration request is on chain, will not update the balance.

I propose we add an info banner on the last step, saying that the migration request has been received and will be processed in the background.

Messina accepts the transaction to be finalized quicker than the migration UX does. The only scenario in which it would not update is if there is a pretty large queue, so I think we can do both. But the info banner is definitely a must in my opinion.

@nortonandreev
Copy link
Contributor Author

I noticed that on migration it can take a while before the wallet syncs again. If possible, it would probably be nice to trigger a sync call to the Dusk chain. This will probably take away some questions/fear from users when the funds do not show up.

That's a good suggestion, however, the problem is that, currently, we have no way to check if the transaction has been processed by Messina. So just triggering a sync after the migration request is on chain, will not update the balance.
I propose we add an info banner on the last step, saying that the migration request has been received and will be processed in the background.

Messina accepts the transaction to be finalized quicker than the migration UX does. The only scenario in which it would not update is if there is a pretty large queue, so I think we can do both. But the info banner is definitely a must in my opinion.

I experimented with this, seems like triggering a sync 15 seconds after a successful confirmation does the job in most cases.

@nortonandreev nortonandreev merged commit fa5ba38 into master Dec 22, 2024
16 checks passed
@nortonandreev nortonandreev deleted the feature-3267 branch December 22, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-wallet: Improve Migration Functionality
2 participants